Add Overridable Parameter Containing Path to Public Directory#43
Open
davidcochrum wants to merge 3 commits intogushphp:masterfrom
Open
Add Overridable Parameter Containing Path to Public Directory#43davidcochrum wants to merge 3 commits intogushphp:masterfrom
davidcochrum wants to merge 3 commits intogushphp:masterfrom
Conversation
davidcochrum
force-pushed
the
master
branch
2 times, most recently
from
0fcda0a to
7d3fa8b
Compare
- Adds `css_to_inline_email_twig_extension.web_root` parameter containing path to web root directory (default remains as `web` just outside kernel root) - Removes unused `use` statements - Adds twig as dev dependency
davidcochrum
force-pushed
the
master
branch
from
7d3fa8b to
2daaf1c
Compare
Contributor
|
👍 |
1 similar comment
|
👍 |
|
Can we get this merged in? |
``` php.INFO: User Deprecated: Using the "Twig_Extension_GlobalsInterface" class is deprecated since Twig version 2.7, use "Twig\Extension\GlobalsInterface" instead."} ```
…message Fix deprecated twig error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We upgraded to Symfony 4 recently and this bundle was failing to locate our css files which had moved from
/webto/publicas recommended. This change adds a parameter so the assumed/webdirectory can be overridden to widen compatibility and flexibility.css_to_inline_email_twig_extension.web_rootparameter containing path to public directory(default remains as
webjust outside kernel root)usestatements